Card Drop Rate

[rosutosefi]

should the loop be <10? I'm having a hard time understanding that, but I'll try to

[Xenocidius]

here is how the spin works

• 1. (init) loop:=0, ncard:=0
• 2. C:=random card from deck, loop:=loop+1
• 3. if loop > 8 goto step 5.
• 4. if C is a tower/pillar goto step 2.
• 5. ncard:=ncard+1
• (error)5bis. loop:=0 (error)
• 6. if C is upped and lvl is not 5 or 6 then C:= downgrade version of C
• 7. if C is a banned card then C:= relic (upped one if C is still upped)
• 8. if ncard <= 4 goto step 2.
• 9. the 4 first cards = the reel

I'll go back and comment my code a bit more.

Although now that you mention it, it should actually be <9. Let me edit that and see what effect it has ...

Edit: Nope, virtually no effect.

[Xenocidius]

Alright, I've heavily commented the code. Can you see any possible errors in it? I'll look over yours too.

[Dark Weaver]

I corrected the python code, I don’t know the python sythax so don’t copy paste it but you should understand the correction.
The error was that the loop counter is incremented at the start and each time a card is found or discarded.
def select(): #This selects 4 cards to use in the spinner
    ncard = 0 #0 cards have been selected
    loop = 0 #No cards have been pillars
    card = [0, 0, 0, 0] #Generate an array for the 4 cards to be used
    while ncard <= 3: #Do this 4 times
        loop = loop + 1 #Add 1 to loop
        index = random.randint(0, (len(cards)-1)) #Pick a random integer/card between 0 and the length of the card array (it holds the card code list)
        if cards[index] not in pillarcodes or loop > 8: #If card is not a pillar or loop >8 then pick the card
            card[ncard] = cards[index] #The nth card in the array is now the card code of the card selected
            ncard = ncard + 1 #Add 1 to number of cards picked
    return card #At the end, output the array of the 4 cards picked

def spin(): #This spins the wheel three times and returns the number of cards won
    wins = 0 #0 cards have been won
    for i in range(0, 3): #repeat 3 times
        card = select() #Generate a card array of the cards picked in the select() function
        card1 = card[random.randint(0, 3)] #Assign one of the 4 cards to the first card spun
        card2 = card[random.randint(0, 3)] #Assign one of the 4 cards to the second card spun
        card3 = card[random.randint(0, 3)] #Assign one of the 4 cards to the third card spun
        if card1 == card2 and card2 == card3: #If all cards are equal
            wins += 1 #Increase number of cards won by 1
    return wins #Return the number of cards won (for use in a different function)

[rosutosefi]

so the pillar loops 8 times only? nooooooooooooooooooooo!

(that's 2 days of simulation down the drain)

[GG]

Ewww MATLAB

When I'm bored ima write the whole thing in C++

[Sevs]

so the pillar loops 8 times only? nooooooooooooooooooooo!

(that's 2 days of simulation down the drain)

no it isnt 8 times it runs through the loop on increments 0,1,2,3,4,5,6,7,8,9 which is 10 times in total

[Xenocidius]

I corrected the python code, I don’t know the python sythax so don’t copy paste it but you should understand the correction.
The error was that the loop counter is incremented at the start and each time a card is found or discarded.
def select(): #This selects 4 cards to use in the spinner
    ncard = 0 #0 cards have been selected
    loop = 0 #No cards have been pillars
    card = [0, 0, 0, 0] #Generate an array for the 4 cards to be used
    while ncard <= 3: #Do this 4 times
        loop = loop + 1 #Add 1 to loop
        index = random.randint(0, (len(cards)-1)) #Pick a random integer/card between 0 and the length of the card array (it holds the card code list)
        if cards[index] not in pillarcodes or loop > 8: #If card is not a pillar or loop >8 then pick the card
            card[ncard] = cards[index] #The nth card in the array is now the card code of the card selected
            ncard = ncard + 1 #Add 1 to number of cards picked
    return card #At the end, output the array of the 4 cards picked

def spin(): #This spins the wheel three times and returns the number of cards won
    wins = 0 #0 cards have been won
    for i in range(0, 3): #repeat 3 times
        card = select() #Generate a card array of the cards picked in the select() function
        card1 = card[random.randint(0, 3)] #Assign one of the 4 cards to the first card spun
        card2 = card[random.randint(0, 3)] #Assign one of the 4 cards to the second card spun
        card3 = card[random.randint(0, 3)] #Assign one of the 4 cards to the third card spun
        if card1 == card2 and card2 == card3: #If all cards are equal
            wins += 1 #Increase number of cards won by 1
    return wins #Return the number of cards won (for use in a different function)

Oh, it increments it after every card picked, not just every pillar picked?

That explains it. I'll run Osiris through it again when I get home.

[rosutosefi]

so the pillar loops 8 times only? nooooooooooooooooooooo!

(that's 2 days of simulation down the drain)

no it isnt 8 times it runs through the loop on increments 0,1,2,3,4,5,6,7,8,9 which is 10 times in total

yay! thank you for telling me, I was about to jump off a building!

Ewww MATLAB

When I'm bored ima write the whole thing in C++

Y U all have grudges on matlab?

[Xenocidius]

Alright, I corrected it but it has minimal effect. It's still returning nearly 0.85 cards per game.

[Dark Weaver]

so the pillar loops 8 times only? nooooooooooooooooooooo!

(that's 2 days of simulation down the drain)

no it isnt 8 times it runs through the loop on increments 0,1,2,3,4,5,6,7,8,9 which is 10 times in total

yay! thank you for telling me, I was about to jump off a building!

Prepare to jump ...

The step 5bis should not be followed, it was an mistake I did previously.
Your matlab code repeat this mistake, you can see that in the results with the very low tower cards won.

I don’t have anything against matlab, it’s more the opposite, but running simulation is way faster in c/c++ than in matlab especially if you don’t use the matlab strength (vector and matrix manipulation) but its weakness (loops on single numbers).

Code: [Select]

tc = 0;
for c = 1:length(a)
    tc = tc + a(c);
    cumulative(c) = tc;
end
for d = 1:length(b)
    tc = tc + b(d);
    cumulative(length(a)+d) = tc;
end

seriously ? I mean ... SERIOUSLY ?????????

Code: [Select]

cumulative = cumsum([a b]);


Code: [Select]

f = floor(rand(1)*(cumulative(end)));
        g = 0;
        cp = 0;
        while g <= length(cumulative) && cp == 0; % use < not <=
            g = g + 1;
            if f < cumulative(g)
                four(e) = g;
                cp = 1;
            end
        end

although correct, why not do it the simple way

Code: [Select]

f = floor(cumulative(end)*rand);
four(e) = find(f < cumulative , 1);


[rosutosefi]

Wee! Thanks for the protips.
(I'm a beginner.)

5bis?